add option to configure log directory #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sorry but I don't quite get why the pre-commit check is failing. Could you take a look? |
|
You need a blank line at the end of files |
auto-merge was automatically disabled
September 5, 2023 06:04
Head branch was pushed to by a user without write access
|
@sean-m-sullivan any idea on why it's falling? |
|
its not anything from the merge, its something underlying, Will need to look into this. |
sean-m-sullivan
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to configure the directory where
setup.shstores the log files.Currently this is only implemented for the
aap_setup_installrole. However it makes sense to add this option to all roles which wrap thesetup.shscript.